Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug #5121

Merged
merged 2 commits into from
Aug 16, 2018
Merged

fixed bug #5121

merged 2 commits into from
Aug 16, 2018

Conversation

davidbenjamin
Copy link
Contributor

@LeeTL1220 This fixes the bug preventing Beri from updating to 4.0.8.0. I will put in an integration test but could you start looking at it now?

@davidbenjamin
Copy link
Contributor Author

@LeeTL1220 I put in a test that fails without the patch.

Copy link
Contributor

@LeeTL1220 LeeTL1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you upload both the bai and bam? Otherwise, looks good feel free to merge.

@droazen
Copy link
Contributor

droazen commented Aug 16, 2018

@davidbenjamin Do we need to do another release for this?

@davidbenjamin
Copy link
Contributor Author

@droazen Yes, please. Sorry for not catching this! Turns out that unpaired reads that pass all the M2 read filters and show evidence of a SNV are rare enough that they don't show up in any of the M2 validations.

@LeeTL1220
Copy link
Contributor

@davidbenjamin @droazen Though the automated tests will now catch this (as of this PR).

@codecov-io
Copy link

codecov-io commented Aug 16, 2018

Codecov Report

Merging #5121 into master will decrease coverage by <.001%.
The diff coverage is 85.714%.

@@               Coverage Diff               @@
##              master     #5121       +/-   ##
===============================================
- Coverage     86.507%   86.507%   -<.001%     
- Complexity     29260     29262        +2     
===============================================
  Files           1814      1814               
  Lines         135635    135641        +6     
  Branches       15063     15063               
===============================================
+ Hits          117334    117339        +5     
  Misses         12833     12833               
- Partials        5468      5469        +1
Impacted Files Coverage Δ Complexity Δ
...hellbender/tools/walkers/mutect/Mutect2Engine.java 90.968% <0%> (-0.645%) 59 <0> (ø)
...r/tools/walkers/mutect/Mutect2IntegrationTest.java 91.349% <100%> (+0.183%) 57 <1> (+1) ⬆️

@droazen droazen merged commit bc98370 into master Aug 16, 2018
@droazen droazen deleted the db_patch branch August 16, 2018 19:03
@davidbenjamin
Copy link
Contributor Author

@droazen thanks for merging. I wouldn't have had a chance until right now at this Toledo rest stop with Wifi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants