-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed bug #5121
Conversation
@LeeTL1220 I put in a test that fails without the patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you upload both the bai and bam? Otherwise, looks good feel free to merge.
b124149
to
bfdb4d0
Compare
@davidbenjamin Do we need to do another release for this? |
@droazen Yes, please. Sorry for not catching this! Turns out that unpaired reads that pass all the M2 read filters and show evidence of a SNV are rare enough that they don't show up in any of the M2 validations. |
@davidbenjamin @droazen Though the automated tests will now catch this (as of this PR). |
Codecov Report
@@ Coverage Diff @@
## master #5121 +/- ##
===============================================
- Coverage 86.507% 86.507% -<.001%
- Complexity 29260 29262 +2
===============================================
Files 1814 1814
Lines 135635 135641 +6
Branches 15063 15063
===============================================
+ Hits 117334 117339 +5
Misses 12833 12833
- Partials 5468 5469 +1
|
@droazen thanks for merging. I wouldn't have had a chance until right now at this Toledo rest stop with Wifi. |
@LeeTL1220 This fixes the bug preventing Beri from updating to 4.0.8.0. I will put in an integration test but could you start looking at it now?