fixed out-of-bounds error in CountNs annotation #6355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidbenjamin Some of the difficulties we are having now may have been prevented had we originally put in tests. |
davidbenjamin
force-pushed
the
db_count_ns
branch
from
0fbe11f to
11dce14
Compare
|
Back to @fleharty |
fleharty
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
@davidbenjamin great, ty! I also ran this branch on the data that caused the problem, and this in fact fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6336. @fleharty could you verify that this branch fixes the error and review? This uses code similar to other annotations that find an offset into a read's bases and are not buggy, as far as we know.