Get rid of ancient, unused option to track unique reads in a LIBS #6410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidbenjamin happy to give this a look and a review after a rebase! |
|
@samuelklee I would be thrilled to rebase and hand it to you for review! |
davidbenjamin
force-pushed
the
db_sam_record_alignment_state
branch
from
ac4cf43 to
101cdcf
Compare
|
@samuelklee It's rebased and passing tests again. |
samuelklee
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
@davidbenjamin just a few minor fixups, otherwise LGTM! Although I might expand the PR description to mention that the option was unused in production code, but you also removed some test code in which it was used. And perhaps ping @droazen for a final check.
Otherwise, thanks for cleaning this up. Here's to deleting (doubly) ancient code!
src/main/java/org/broadinstitute/hellbender/utils/locusiterator/LocusIteratorByState.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/utils/locusiterator/LocusIteratorByState.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/utils/locusiterator/LocusIteratorByState.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/utils/locusiterator/LocusIteratorByState.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1495. @droazen Adam's comments suggest that this feature has been unused since before GATK 3. May we put it to rest?