Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minValue/minRecommended value to ApplyBQSRArgumentCollection #6438

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Add minValue/minRecommended value to ApplyBQSRArgumentCollection #6438

merged 1 commit into from
Feb 4, 2020

Conversation

lbergelson
Copy link
Member

  • Implemented a suggestion from an ancient TODO in ApplyBQSRArgumentCollection which was waiting for a now available barclay feature

@lbergelson
Add minValue/minRecommended value to ApplyBQSRArgumentCollection
94fa585 
* Implemented a suggestion from an ancient TODO in ApplyBQSRArgumentCollection which was waiting for a now available barclay feature
@lbergelson lbergelson requested a review from ldgauthier February 3, 2020 18:00
@lbergelson
Copy link
Member Author

@ldgauthier PR for you! Hopefully simple...

@ldgauthier
Copy link
Contributor

I totally missed the Barclay update that added these... over a year ago. LGTM!

@lbergelson lbergelson merged commit 89e8c63 into master Feb 4, 2020
@lbergelson lbergelson deleted the lb_resolve_old_bqsr_todo branch February 4, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldgauthier ldgauthier ldgauthier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbergelson @ldgauthier