Error message for no callable sites in M2 #6445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbenjamin
force-pushed
the
db_no_callable_sites
branch
from
13cccf3 to
2b2d56b
Compare
takutosato
approved these changes
Feb 10, 2020
davidbenjamin
force-pushed
the
db_no_callable_sites
branch
from
638fc74 to
62c2cac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@takutosato This error should be thrown once detected. Currently it leads to a divide-by-zero downstream, which only throws an error even further downstream when the NaN shows up.