-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade numpy to version 1.17.0 #6494
Conversation
@samuelklee @mwalker174 @lucidtronix Tests seem to pass with this (numpy 1.18 seems to cause runtime errors for CNN, but 1.17 seems to work ok), so this should at least get us up to a version that addresses the gcc issues in this forum post. |
Great, thanks for adding this @cmnbroad! Let me manually check that there weren't any numerical changes in the gCNV WDL tests. @asmirnov239 and Jack might also want to test on some small, real data. Probably overkill, but just to be safe... We'll get back to you! |
Did some numerical spot checks against master, looks like we're typically good to 10+ decimal places for the very small gCNV WDL test data. I'm fine with this going in without checking on real data first, but I'll tell Andrey and Jack to keep an eye out. Thanks again for updating! |
d6a3c0f
to
1e03a85
Compare
ad3bc5d
to
e5ca093
Compare
Noticed inconsistencies, trying to fix over in sl_reshape.
Reminder to myself to incorporate version checks from this branch over in #5026. |
Fixes #6480. Note that xbyak issue is unchanged and still exists with this upgrade.
This also contains a test for some of the key python packages to verify that they are resolved by Conda to the version of the package requested in the .yml file.