Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where single-base intervals led to no calls #6507

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

davidbenjamin
Copy link
Contributor

Closes #6495. @ldgauthier do you want this one?

@gatk-bot
Copy link

gatk-bot commented Mar 17, 2020

Travis reported job failures from build 29539
Failures in the following jobs:

Test Type JDK Job ID Logs
R openjdk8 29539.6 logs
python openjdk8 29539.5 logs
variantcalling openjdk8 29539.4 logs
unit openjdk8 29539.3 logs
integration openjdk8 29539.2 logs

@gatk-bot
Copy link

Travis reported job failures from build 29541
Failures in the following jobs:

Test Type JDK Job ID Logs
variantcalling openjdk8 29541.4 logs

@davidbenjamin davidbenjamin force-pushed the db_one_base_interval_bug branch from 8e8b0ee to e08e410 Compare March 17, 2020 17:20
Copy link
Contributor

@ldgauthier ldgauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, pending tests passing. I find it a little disconcerting that we apparently were skipping a mitochondrial variant in the M2 tests, but at least now we have a regression test for that.

@davidbenjamin
Copy link
Contributor Author

I find it a little disconcerting that we apparently were skipping a mitochondrial variant in the M2 tests

Nothing to worry about — that number change (if that's what you're referring to) is just a hard-coded read count. It changes every time windows are adjusted.

@davidbenjamin davidbenjamin merged commit d89c0e6 into master Mar 18, 2020
@davidbenjamin davidbenjamin deleted the db_one_base_interval_bug branch March 18, 2020 01:45
@ldgauthier
Copy link
Contributor

Oh, good, I thought it was the variant position!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HaplotypeCaller doesn't detect alternate alleles with 1 bp intervals
3 participants