Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched CigarBuilder's order for adjacent indels to be deletion first #6510

Merged
merged 2 commits into from
Mar 25, 2020

Conversation

davidbenjamin
Copy link
Contributor

Closes #6473 and resolves a few forum issues about GenomicsDB not supporting MNPs.

@ldgauthier

Copy link
Contributor

@ldgauthier ldgauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did see the updated CigarBuilder unit tests, but I thought you said you'd add a regression test with the user's data? Not a deal breaker for me, though. Otherwise looks good.

@davidbenjamin
Copy link
Contributor Author

but I thought you said you'd add a regression test with the user's data

I must have. There is a regression test now.

@davidbenjamin davidbenjamin merged commit bdb2e15 into master Mar 25, 2020
@davidbenjamin davidbenjamin deleted the db_adjacent_indels branch March 25, 2020 04:44
@mlaylwar
Copy link

I am experiencing this issue, which I thought was solved. I have used version 4.1.7.0 haplotype caller, then when I use combineGVCFs I receive the error: A USER ERROR has occurred: Bad input: Combining gVCFs containing MNPs is not supported. Unknown contained a MNP at A1:684599

I didn't set any value for -max-mnp-dist as the docs say that default is already set to 0. Any idea how to get around this error?

Thanks

@davidbenjamin
Copy link
Contributor Author

@mlaylwar What are the reference and MNP alleles at this position?

@mlaylwar
Copy link

mlaylwar commented Aug 20, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutect2 (GATK 4.1.5.0) emitting MNPs despite max-mnp-distance 0
3 participants