Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable htsget tests #6668

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Re-enable htsget tests #6668

merged 1 commit into from
Jun 19, 2020

Conversation

lbergelson
Copy link
Member

Re-enable tests for htsget now that the reference server is back to a stable version

  • Some tests were disabled due to issues with the htsget reference server, now that it's back to running an older stable version
    the tests which work on that version are re-enabled.

  • Partial fix for Re-enable htsget tests once the server problems are fixed #6640 another commit will be needed when the server is upgraded to support fields/tags

The field test had to be disabled because it doesn't seem like the current server version supports the parameter correctly.

… stable version

* Some tests were disabled due to issues with the htsget reference server, now that it's back to running an older stable version
  the tests which work on that version are re-enabled.
@lbergelson
Copy link
Member Author

@andersleung Could you take a look at this one?

@lbergelson
Copy link
Member Author

@jamesemery Could I get a 👍 on this from you. Anders reviewed it but it's not counting him since he doesn't have write access.

@lbergelson lbergelson merged commit 248c94a into master Jun 19, 2020
@lbergelson lbergelson deleted the lb_reenable_htsget_tests branch June 19, 2020 21:23
jonn-smith pushed a commit that referenced this pull request Jul 14, 2020
… stable version (#6668)

* Re-enable tests for htsget now that the reference server is back to a stable version
  Some tests were disabled due to issues with the htsget reference server, now that it's back to running an older stable version. 
The tests which work on this version are re-enabled now.
* Partial fix for #6640 another commit will be needed when the server is upgraded to support fields/tags
* The field test had to be disabled because it doesn't seem like the current server version supports the parameter correctly.
@lbergelson lbergelson added the GA4GH Collaboration with GA4GH label Sep 1, 2020
mwalker174 pushed a commit that referenced this pull request Nov 3, 2020
… stable version (#6668)

* Re-enable tests for htsget now that the reference server is back to a stable version
  Some tests were disabled due to issues with the htsget reference server, now that it's back to running an older stable version. 
The tests which work on this version are re-enabled now.
* Partial fix for #6640 another commit will be needed when the server is upgraded to support fields/tags
* The field test had to be disabled because it doesn't seem like the current server version supports the parameter correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GA4GH Collaboration with GA4GH
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants