Fix crash when building with a JDK instead of a JRE #6676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* A previouus change left a reference to an uninitialized property in build.gradle. This caused a crash when trying to produce an error message warning that the JDK was not found. Ex: Caused by: groovy.lang.MissingPropertyException: Could not get unknown property 'requiredJavaVersion' for root project 'gatk' of type org.gradle.api.Project * Fix the crash by removing the reference to the missing property.
droazen
reviewed
Jun 24, 2020
| @@ -147,7 +147,7 @@ def ensureBuildPrerequisites(largeResourcesFolder, buildPrerequisitesMessage, sk | |||
| if (JavaVersion.current().isJava8() && ToolProvider.getSystemToolClassLoader() == null) { | |||
| throw new GradleException( | |||
| "The ClassLoader obtained from the Java ToolProvider is null. " | |||
| + "A Java $requiredJavaVersion JDK must be installed. $buildPrerequisitesMessage") | |||
| + "A full Java 8 or 11 JDK must be installed, check that you are not using a JRE. $buildPrerequisitesMessage") | |||
There was a problem hiding this comment.
Are you sure that we want to claim support for 11 here?
There was a problem hiding this comment.
I think so. We claim it on line 153 as well.
jonn-smith
pushed a commit
that referenced
this pull request
Jul 14, 2020
* A previouus change left a reference to an uninitialized property in build.gradle. This caused a crash when trying to produce an error message warning that the JDK was not found. Ex: Caused by: groovy.lang.MissingPropertyException: Could not get unknown property 'requiredJavaVersion' for root project 'gatk' of type org.gradle.api.Project * Fix the crash by removing the reference to the missing property.
mwalker174
pushed a commit
that referenced
this pull request
Nov 3, 2020
* A previouus change left a reference to an uninitialized property in build.gradle. This caused a crash when trying to produce an error message warning that the JDK was not found. Ex: Caused by: groovy.lang.MissingPropertyException: Could not get unknown property 'requiredJavaVersion' for root project 'gatk' of type org.gradle.api.Project * Fix the crash by removing the reference to the missing property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previouus change left a reference to an uninitialized property in build.gradle.
This caused a crash when trying to produce an error message warning that the JDK was not found.
Ex: Caused by: groovy.lang.MissingPropertyException: Could not get unknown property 'requiredJavaVersion' for root project 'gatk' of type org.gradle.api.Project
Fix the crash by removing the reference to the missing property.