fix to correctly handle space in sample name #6773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we fix the sample names? This sort of nonesense always breaks everything. |
|
I don't mean that this fix will break things, but stupid sample names will always cause OTHER problems in addition. |
|
Ah @lbergelson, always trying to fix the rest of the world instead of accepting the inevitability of problematic characters everywhere in genomics. Even we ourselves, who should know better, recently set up a new project with a period in its name, I've heard... :) |
mwalker174
pushed a commit
that referenced
this pull request
Nov 3, 2020
* update awk to split only on tabs to work around sample id with a space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.