-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optionally provide sample-map-file instead of sample-map-table #6872
Conversation
@meganshand do you have any other ideas for how I can fix the test failure? |
The issue with the tests is that this PR is from a fork so the tests don't have access to the permissions we need for BigQuery in the variantstore WDL tests. I need to fix this for the future (by making sure those tests don't run when the PR is from a fork), but I don't think that test failure should block this PR. |
What's the protocol for getting this PR merged - @meganshand are you the right reviewer? |
@@ -50,7 +51,7 @@ public StorageAPIAvroReader(final TableReference tableRef, final String rowRestr | |||
try { | |||
this.client = BigQueryStorageClient.create(); | |||
|
|||
final String parent = String.format("projects/%s", tableRef.tableProject); | |||
final String parent = String.format("projects/%s", BigQueryOptions.getDefaultInstance().getProjectId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two implication here -- you need permission, but also this is where the cost of using the storage API will be attributed. This was set to the destination table project since (a) the user just created that table so they should have permission and (b) the cost for the temporary storage of that table and the cost to use the read API against it should go to to the same place.
If we need the extra flexibility to provide an independent project here, rather than the default I would make another argument like "read-api-project" or something that can be passed in to override the default of the table project
I think it should be good for another pass @kcibul @meganshand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* optionally provide sample-map-file instead of sample-map-table * fix variantstore test * trying to fix test * pass in read project id * empty string -> null * make read-project-id optional Co-authored-by: Megan Shand <mshand@broadinstitute.org>
* optionally provide sample-map-file instead of sample-map-table * fix variantstore test * trying to fix test * pass in read project id * empty string -> null * make read-project-id optional Co-authored-by: Megan Shand <mshand@broadinstitute.org>
* optionally provide sample-map-file instead of sample-map-table * fix variantstore test * trying to fix test * pass in read project id * empty string -> null * make read-project-id optional Co-authored-by: Megan Shand <mshand@broadinstitute.org>
* optionally provide sample-map-file instead of sample-map-table * fix variantstore test * trying to fix test * pass in read project id * empty string -> null * make read-project-id optional Co-authored-by: Megan Shand <mshand@broadinstitute.org>
* optionally provide sample-map-file instead of sample-map-table * fix variantstore test * trying to fix test * pass in read project id * empty string -> null * make read-project-id optional Co-authored-by: Megan Shand <mshand@broadinstitute.org>
* optionally provide sample-map-file instead of sample-map-table * fix variantstore test * trying to fix test * pass in read project id * empty string -> null * make read-project-id optional Co-authored-by: Megan Shand <mshand@broadinstitute.org>
Changes
--cohort-sample-file
can be used instead of--cohort-sample-table
to provide the (sample_id,sample_name) map