-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WDL to run feature extract, VQSR, and upload #6966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
there are a lot of details in this wdl that I'd like to know more about. maybe we can walk through it at standup.
cat ~{filter_set_name}.snps.recal.tsv ~{filter_set_name}.indels.recal.tsv | grep -v filter_set_name | grep -v "#" > filter_set_load.tsv | ||
|
||
# BQ load likes a : instead of a . after the project | ||
bq_info_table=$(echo ~{fq_info_destination_table} | sed s/\\./:/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's weird that you need a : after the project. in our other scripts, we specify the project with --project_id=~{project_id}
and then we don't include it in the dataset.table. also, when i was doing a bq query, the : was needed when i was using legacy mode and the . otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah you can supply the default project with --project_id OR can you supply a fully qualified name. Since for all the other scripts we tend to take in a FQ table name (project.dataset.table) I kept this the same from an input perspective for user consistency, but that means we have to fiddle it here to get it in the right format for bq load
disk_size = large_disk | ||
} | ||
|
||
call SNPsVariantRecalibrator as SNPsVariantRecalibratorClassic { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - we could remove the as here (i'm guessing we used to have a classic and non classic mode)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah -- I think we're going to have a "non-classic" mode as well once we start scale testing. The WARP pipeline has it for > 10k wgs samples... but it's a bunch of logic. Happy to remove the "as ..." for now though
|
||
df -h | ||
min_location=$(echo "~{chrom_id} * ~{chrom_offset}" | bc) | ||
max_location=$(echo "( ~{chrom_id} + 1 ) * ~{chrom_offset}" | bc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bc - TIL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧰
* WDL to run feature extract, VQSR, and upload * PR feedback
* WDL to run feature extract, VQSR, and upload * PR feedback
* WDL to run feature extract, VQSR, and upload * PR feedback
* WDL to run feature extract, VQSR, and upload * PR feedback
* WDL to run feature extract, VQSR, and upload * PR feedback
No description provided.