Reduce memory and CPU for CreateImportTsvs task, check for files before attempting load #7121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorgantaylor
commented
Mar 3, 2021
.dockstore.yml
Outdated
| @@ -57,6 +57,7 @@ workflows: | |||
| branches: | |||
| - master | |||
| - ah_var_store | |||
| - mmt_reduce_mem | |||
There was a problem hiding this comment.
will remove this before merging
kcibul
pushed a commit
that referenced
this pull request
Mar 9, 2021
…re attempting load (#7121) * reduce memory for ImportGenomes and add this branch to dockstore yml * do not fail bq load if no files to ingest * remove feature branch from dockstore
mmorgantaylor
added a commit
that referenced
this pull request
Apr 6, 2021
…re attempting load (#7121) * reduce memory for ImportGenomes and add this branch to dockstore yml * do not fail bq load if no files to ingest * remove feature branch from dockstore
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both of these are updates to the ImportGenomes wdl:
bq load, check for existing files in the gs bucket. only runbq loadif there are matching files in the bucket. this will prevent an error if you run a subset of samples corresponding to a larger sample map such that you've created a pet_002 table but there aren't any samples to load for pet_002 yet. this was tested in Terra and worked as expected.