Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the gcloud package signing key during the docker build #7180

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

droazen
Copy link
Contributor

@droazen droazen commented Apr 2, 2021

Previously we were relying on the gcloud package signing key retrieved
during build of the GATK base image. However, the base image is updated
so infrequently that it's possible that the key it uses has expired. To
address this, we now retrieve an updated key at the start of the Docker
build.

Previously we were relying on the gcloud package signing key retrieved
during build of the GATK base image. However, the base image is updated
so infrequently that it's possible that the key it uses has expired. To
address this, we now retrieve an updated key at the start of the Docker
build.
@droazen
Copy link
Contributor Author

droazen commented Apr 2, 2021

@lbergelson or @jonn-smith please review

@droazen droazen requested review from lbergelson and jonn-smith April 2, 2021 15:38
@droazen droazen self-assigned this Apr 2, 2021
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@droazen Looks good to me. 👍

@droazen droazen merged commit bc5010a into master Apr 2, 2021
@droazen droazen deleted the dr_update_gcloud_key_in_dockerfile branch April 2, 2021 17:04
kcibul pushed a commit that referenced this pull request Apr 6, 2021
Previously we were relying on the gcloud package signing key retrieved
during build of the GATK base image. However, the base image is updated
so infrequently that it's possible that the key it uses has expired. To
address this, we now retrieve an updated key at the start of the Docker
build.
mmorgantaylor pushed a commit that referenced this pull request Apr 6, 2021
* Disabling some spark dataproc tests because of dependency issues. (#7170)

Will re-enable in the near future.

* Update the gcloud package signing key during the docker build (#7180)

Previously we were relying on the gcloud package signing key retrieved
during build of the GATK base image. However, the base image is updated
so infrequently that it's possible that the key it uses has expired. To
address this, we now retrieve an updated key at the start of the Docker
build.

* fix compilation problem

Co-authored-by: Jonn Smith <jonn-smith@users.noreply.github.com>
Co-authored-by: droazen <droazen@broadinstitute.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants