Rename "metadata" table to "sample_info" table, fix vet schema #7196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorgantaylor
commented
Apr 9, 2021
kcibul
approved these changes
Apr 9, 2021
|
dont we also need to update |
mmorgantaylor
force-pushed
the
mmt_rename_metadata
branch
from
875d324 to
60bd7c5
Compare
mmorgantaylor
changed the title
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
specops issue #265 https://github.com/broadinstitute/dsp-spec-ops/issues/265
in addition to renaming the metadata table (in both CreateVariantIngestFiles tool and ImportGenomes wdl), this PR:
this was tested by running ImportGenomes.wdl in Terra and the sample_info table gets created & populated as expected.
note: ImportArrays.wdl and array tooling were not updated