Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GKL version 0.8.8 #7203

Merged
merged 3 commits into from
May 14, 2021
Merged

Update to GKL version 0.8.8 #7203

merged 3 commits into from
May 14, 2021

Conversation

droazen
Copy link
Contributor

@droazen droazen commented Apr 14, 2021

No description provided.

@droazen
Copy link
Contributor Author

droazen commented Apr 14, 2021

@lbergelson please review

@gatk-bot
Copy link

gatk-bot commented Apr 14, 2021

Travis reported job failures from build 33752
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud openjdk11 33752.14 logs
cloud openjdk8 33752.1 logs
unit openjdk11 33752.13 logs
integration openjdk11 33752.12 logs
variantcalling openjdk8 33752.4 logs
unit openjdk8 33752.3 logs
conda openjdk8 33752.5 logs
integration openjdk8 33752.2 logs
cloud openjdk11 33752.14 logs
cloud openjdk8 33752.1 logs
unit openjdk11 33752.13 logs
integration openjdk11 33752.12 logs
variantcalling openjdk8 33752.4 logs
conda openjdk8 33752.5 logs

@lbergelson
Copy link
Member

Oh man. They beat me to it.

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@droazen
Copy link
Contributor Author

droazen commented Apr 14, 2021

Seeing some test failures unfortunately due to the following error:

java.lang.NoClassDefFoundError: Could not initialize class org.apache.hadoop.fs.FileSystem
        at org.apache.hadoop.fs.Path.getFileSystem(Path.java:365)

@droazen droazen force-pushed the dr_update_to_gkl_0.8.8 branch from e7556df to 7213968 Compare April 15, 2021 17:42
@gatk-bot
Copy link

gatk-bot commented Apr 15, 2021

Travis reported job failures from build 33778
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud openjdk8 33778.1 logs
cloud openjdk11 33778.14 logs
unit openjdk11 33778.13 logs
integration openjdk11 33778.12 logs
variantcalling openjdk8 33778.4 logs
unit openjdk8 33778.3 logs

@droazen droazen force-pushed the dr_update_to_gkl_0.8.8 branch from 7213968 to f4bf827 Compare April 30, 2021 16:37
@droazen
Copy link
Contributor Author

droazen commented Apr 30, 2021

Added a commit to remove the FPGA PairHMM implementation as an option from GATK, since it's been removed from the GKL.

@gatk-bot
Copy link

gatk-bot commented Apr 30, 2021

Travis reported job failures from build 34034
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud openjdk8 34034.1 logs
cloud openjdk11 34034.14 logs
unit openjdk11 34034.13 logs
integration openjdk11 34034.12 logs
variantcalling openjdk8 34034.4 logs
conda openjdk8 34034.5 logs
unit openjdk8 34034.3 logs
integration openjdk8 34034.2 logs

* log4j-jcl's version needs to match the other log4j library versions
* log4j libraries api, core, and jcl set too 2.13.1
@lbergelson
Copy link
Member

@droazen I believe I've found the problem here and pushed a fix.

@lbergelson
Copy link
Member

We'll see if tests pass.

@droazen
Copy link
Contributor Author

droazen commented May 14, 2021

Thank you @lbergelson for the fix! For once a dependency conflict that turns out to be simple!

@droazen droazen merged commit 89a87ca into master May 14, 2021
@droazen droazen deleted the dr_update_to_gkl_0.8.8 branch May 14, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants