Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always login to docker on travis instead of qualifying it #7256

Merged
merged 1 commit into from
May 14, 2021

Conversation

lbergelson
Copy link
Member

  • It turned out we weren't logging in to dockerhub on the wdl test cases in travis because I misunderstood how the DOCKER_TEST flag was used.
  • Now we unconditionally authenticate to dockerhub in all test shards instead of trying to pick only the relevant ones.

* It turned out we weren't logging in to dockerhub on the wdl test cases in travis because I misunderstood how the DOCKER_TEST flag was used.
* Now we unconditionally authenticate to dockerhub in all test shards instead of trying to pick only the relevant ones.
@lbergelson
Copy link
Member Author

@kcibul @cmnbroad This should hopefully fix the problems you've both been seeing.

It turned out we weren't logging into docker on the wdl test branches because they don't set DOCKER_TEST but they still build docker images. I was confused about how that variable was used.

Copy link
Contributor

@kcibul kcibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- let's see if the tests pass 🤣

@lbergelson
Copy link
Member Author

Failures are non-deterministic so passing is a pretty weak signal.

@lbergelson lbergelson merged commit c74323a into master May 14, 2021
@lbergelson lbergelson deleted the lb_amend_docker_login branch May 14, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants