-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove calls to filter Numt and low het sites #7325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a few more instances of max_low_het_sites
to be deleted. Thanks!
@@ -11,7 +11,6 @@ workflow AlignAndCall { | |||
|
|||
input { | |||
File unmapped_bam | |||
Float? autosomal_coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also delete the max_low_het_sites
workflow input?
@@ -15,7 +15,6 @@ workflow MitochondriaPipeline { | |||
File wgs_aligned_input_bam_or_cram | |||
File wgs_aligned_input_bam_or_cram_index | |||
String contig_name = "chrM" | |||
Float autosomal_coverage = 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max_low_het_sites
should be deleted from this WDL too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I just remembered one more place to delete these two args, the example inputs json and probably also the test inputs json (gatk/scripts/m2_cromwell_tests/test_mitochondria_m2_wdl.json)
But after that 👍
numt and low het filters are no longer being used