Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove calls to filter Numt and low het sites #7325

Merged
merged 5 commits into from
Aug 18, 2021
Merged

Conversation

ahaessly
Copy link
Contributor

numt and low het filters are no longer being used

@ahaessly ahaessly requested a review from meganshand June 21, 2021 16:00
Copy link
Contributor

@meganshand meganshand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few more instances of max_low_het_sites to be deleted. Thanks!

@@ -11,7 +11,6 @@ workflow AlignAndCall {

input {
File unmapped_bam
Float? autosomal_coverage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also delete the max_low_het_sites workflow input?

@@ -15,7 +15,6 @@ workflow MitochondriaPipeline {
File wgs_aligned_input_bam_or_cram
File wgs_aligned_input_bam_or_cram_index
String contig_name = "chrM"
Float autosomal_coverage = 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max_low_het_sites should be deleted from this WDL too.

Copy link
Contributor

@meganshand meganshand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I just remembered one more place to delete these two args, the example inputs json and probably also the test inputs json (gatk/scripts/m2_cromwell_tests/test_mitochondria_m2_wdl.json)

But after that 👍

@ahaessly ahaessly merged commit 962f1d1 into master Aug 18, 2021
@ahaessly ahaessly deleted the ah_remove_mito_filters branch August 18, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants