-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Sites only step from the VAT creation WDL #7510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoriCremer
force-pushed
the
rc-remove-sites-only-step
branch
4 times, most recently
from
October 22, 2021 20:30
a2210d0
to
ea40cc7
Compare
RoriCremer
force-pushed
the
rc-remove-sites-only-step
branch
2 times, most recently
from
October 22, 2021 20:43
a2a5102
to
e2603bb
Compare
rsasch
approved these changes
Oct 25, 2021
rsasch
reviewed
Oct 25, 2021
Comment on lines
214
to
219
#awk '{print $2}' ~{subpopulation_sample_list} | tail -n +2 | sort -u > collected_subpopulations.txt | ||
#bcftools query --list-samples ~{local_input_vcf} | sort -u > collected_samples.txt | ||
|
||
#wc -l collected_subpopulations.txt | ||
#wc -l collected_samples.txt | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these lines commented out?
bcftools view -i 'N_ALT>500 || REF~"N"' ~{local_input_vcf} | bcftools query -f '%CHROM\t%POS\t%ID\t%REF\t%ALT\n' > track_dropped.tsv | ||
|
||
## Since Nirvana cant handle N as a base, drop them for now and keep track of the lines dropped | ||
## bcftools view -e 'REF~"N"' ~{local_input_vcf} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this line commented out?
RoriCremer
force-pushed
the
rc-remove-sites-only-step
branch
from
October 26, 2021 19:13
e2603bb
to
2602a56
Compare
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the creation of the sites only vcf into the bcftools step