Quoting of table names #7666
Merged
Quoting of table names #7666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsasch
suggested changes
Feb 8, 2022
kcibul
commented
Feb 14, 2022
| "UNION DISTINCT " \ | ||
| "SELECT i.sample_name FROM items i WHERE i.sample_id IN (SELECT sample_id FROM ~{dataset_name}.sample_load_status) " \ | ||
| | sed -e '/sample_name/d' > duplicates | ||
| echo "WITH items as (SELECT s.sample_id, s.sample_name, s.is_loaded FROM \`${TEMP_TABLE}\` t left outer join \`${SAMPLE_INFO_TABLE}\` s on (s.sample_name = t.sample_name)) " >> query.sql |
There was a problem hiding this comment.
Had to adopt this approach of putting the SQL into a temp file and then run it so we could get around the mix of single-quotes, double-quotes, need for $ variable interpretation in bash and the backticks required for BQ.
kcibul
commented
Feb 14, 2022
| @@ -433,7 +434,7 @@ task GetSampleIds { | |||
| python3 -c "from math import ceil; print(ceil($min_sample_id/~{samples_per_table}))" > min_sample_id | |||
|
|
|||
| bq --project_id=~{project_id} query --format=csv --use_legacy_sql=false -n ~{num_samples} \ | |||
| "SELECT sample_id, samples.sample_name FROM ~{dataset_name}.~{table_name} AS samples JOIN ${TEMP_TABLE} AS temp ON samples.sample_name=temp.sample_name" > sample_map | |||
| "SELECT sample_id, samples.sample_name FROM \`~{dataset_name}.~{table_name}\` AS samples JOIN \`${TEMP_TABLE}\` AS temp ON samples.sample_name=temp.sample_name" > sample_map | |||
There was a problem hiding this comment.
An example of where we need $ interpolation (so we can't use single quotes) but also have the back-ticks to deal with
rsasch
approved these changes
Feb 14, 2022
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table names in GvsAssignId were not quoted with backticks, which is fine except if your dataset name starts with a number… which is a total valid identifier, but requires quoting.
Recently we had a customer (AoU) supply a dataset with the name
1kg_wgswhich exposed this problem