-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There something about split intervals #7694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoriCremer
commented
Feb 23, 2022
src/main/java/org/broadinstitute/hellbender/tools/walkers/SplitIntervals.java
Show resolved
Hide resolved
@RoriCremer These arguments were added to |
…refix to interval filenames
…or interval filenames
…ile name number of digits
This reverts commit 64f8204.
@rsasch LGTM.... worked for me, and it looks like the testing all passed---lmk how else I can help |
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on the ah_var_store branch, the SplitIntervals file didn't match up with main, and it looks like there are some problems with the --interval-file-num-digits 10 flag.
I need to further investigate what is going on (and why we reverted!??!)