Add haploid support to GnarlyGenotyper #7750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
2 tasks
Merged
meganshand
reviewed
Jul 12, 2023
|
|
||
| for ( final Genotype g : vc.getGenotypes() ) { | ||
| final String name = g.getSampleName(); | ||
| if(g.getPloidy() != ASSUMED_PLOIDY && !isGDBnoCall(g)) { | ||
| /*if(g.getPloidy() != ASSUMED_PLOIDY && !isGDBnoCall(g)) { |
There was a problem hiding this comment.
can delete this commented out section
| /** | ||
| * Some legacy versions of GenomicsDB report no-calls as `0` or `.` | ||
| * @param g genotype to check | ||
| * @return true if this is a genotype that should be represented as a ploidy-aware, spec compliant no-call | ||
| */ | ||
| private static boolean isGDBnoCall(final Genotype g) { | ||
| return g.getPloidy() == 1 && (g.getAllele(0).isReference() || g.getAllele(0).isNoCall()); | ||
| //return g.getPloidy() == 1 && (g.getAllele(0).isReference() || g.getAllele(0).isNoCall()); |
| gb.attribute(GATKVCFConstants.GENOTYPE_QUALITY_BY_ALT_CONFIDENCE, ALTGQ); | ||
| gb.noPL(); | ||
| } | ||
|
|
||
| /** | ||
| * Some legacy versions of GenomicsDB report no-calls as `0` or `.` | ||
| * @param g genotype to check | ||
| * @return true if this is a genotype that should be represented as a ploidy-aware, spec compliant no-call |
There was a problem hiding this comment.
I think you can update this comment since it's no longer checking the ploidy
| @@ -1,5 +1,8 @@ | |||
| package org.broadinstitute.hellbender.tools.walkers; | |||
|
|
|||
| import com.google.errorprone.annotations.Var; | |||
| @@ -217,4 +224,26 @@ public void testOnEmptyAnnotations() { | |||
| Assert.assertEquals(sors.get(1), VCFConstants.MISSING_VALUE_v4); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testHaploidInput() { | |||
| final File haploidGVCF = new File(getToolTestDataDir(), "haploid.mini.g.vcf"); | |||
There was a problem hiding this comment.
I think haploid.mini.g.vcf is missing
ldgauthier
force-pushed
the
ldg_gnarlyForHaploids
branch
from
ca3abf3 to
56f8dd4
Compare
|
Github actions tests reported job failures from actions build 5533855739
|
meganshand
approved these changes
Jul 17, 2023
| @@ -53,13 +53,19 @@ public void assertThatExpectedOutputUpdateToggleIsDisabled() { | |||
| @DataProvider(name="VCFdata") | |||
| public Object[][] getVCFdata() { | |||
| return new Object[][]{ | |||
| /* | |||
There was a problem hiding this comment.
Did you want this to be commented out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7690