Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix initial 0 downloads bug #7794

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

lbergelson
Copy link
Member

This fixes the first day's downloads on a new release which previously were set to 0.

@jonn-smith This is what I was talking about.

@lbergelson lbergelson requested a review from jonn-smith April 19, 2022 21:14
@gatk-bot
Copy link

gatk-bot commented Apr 19, 2022

Travis reported job failures from build 38956
Failures in the following jobs:

Test Type JDK Job ID Logs
conda openjdk8 38956.5 logs
conda openjdk8 38956.5 logs
conda openjdk8 38956.5 logs

Copy link
Collaborator

@jonn-smith jonn-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good. I think this may have been a typo from my last refactor.

@jonn-smith
Copy link
Collaborator

Code is now deployed.

@lbergelson lbergelson force-pushed the lb_fix_initial_downloadCounts branch from 3616bc1 to a018716 Compare April 25, 2022 22:21
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #7794 (a018716) into master (4ad1283) will increase coverage by 0.001%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #7794       +/-   ##
===============================================
+ Coverage     86.941%   86.942%   +0.001%     
- Complexity     36860     36861        +1     
===============================================
  Files           2211      2211               
  Lines         173376    173376               
  Branches       18710     18710               
===============================================
+ Hits          150734    150736        +2     
+ Misses         16055     16054        -1     
+ Partials        6587      6586        -1     
Impacted Files Coverage Δ
.../hellbender/utils/python/PythonUnitTestRunner.java 78.689% <0.000%> (+3.279%) ⬆️

@lbergelson lbergelson merged commit af69f8d into master Apr 27, 2022
@lbergelson lbergelson deleted the lb_fix_initial_downloadCounts branch April 27, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants