Improve import error message [VS-437] #7855
Conversation
| message = "The number of external_sample_names, sample input_vcfs and sample input_vcf_indexes are not the same." | ||
| external_sample_count = length(external_sample_names), | ||
| input_length = input_length, | ||
| input_indexes_length = input_indexes_length |
There was a problem hiding this comment.
do we use TerminateWorkflow anywhere else? We're making it very specific here---does it just echo the message?!?!
There was a problem hiding this comment.
Yeah the TerminateWorkflow name seems very generic but actually it's only ever called from this workflow for this reason.
There was a problem hiding this comment.
But it could be more generic if it was in GvsUtils and only took the error message as a string argument.
There was a problem hiding this comment.
yes this was my thinking as well. I like that much better
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7855 +/- ##
================================================
Coverage ? 86.293%
Complexity ? 35189
================================================
Files ? 2170
Lines ? 164876
Branches ? 17784
================================================
Hits ? 142277
Misses ? 16276
Partials ? 6323 |
mcovarr
force-pushed
the
vs_437_improve_import_error_message
branch
from
80c909f to
0cbfb14
Compare
mcovarr
force-pushed
the
vs_437_improve_import_error_message
branch
from
042483a to
dac8f52
Compare
| command <<< | ||
| set -o errexit | ||
|
|
||
| # To avoid issues with special characters within the message, write the message to a file. |
There was a problem hiding this comment.
oh no that sounds super annoying!
No description provided.