Update Quickstart & Integration to use re-blocked v2 gVCFs [VS-491] #7924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7924 +/- ##
================================================
Coverage ? 85.943%
Complexity ? 35050
================================================
Files ? 2170
Lines ? 164888
Branches ? 17785
================================================
Hits ? 141710
Misses ? 16895
Partials ? 6283 |
mcovarr
reviewed
Jun 29, 2022
mcovarr
approved these changes
Jun 29, 2022
RoriCremer
reviewed
Jun 29, 2022
| @@ -10,15 +10,14 @@ Through this QuickStart you will learn how to use the Broad Genomic Variant Stor | |||
| This quickstart assumes that you are familiar with Terra workspaces, the data model and providing input parameters and launching workflows. | |||
|
|
|||
| 1. You will need to have or create a BigQuery dataset (we'll call this `dataset_name` later on). | |||
| 2. Grant the "BigQuery Data Editor" role on that **dataset** to your Terra PROXY group. Your proxy group name can be found on your Terra Profile page and look something like `PROXY_12345678901234567890@firecloud.org`. | |||
There was a problem hiding this comment.
did we used to need this? I'm so curious about where this came from!
RoriCremer
reviewed
Jun 29, 2022
| "gs://fc-2b4456d7-974b-4b67-90f8-63c2fd2c03d4/gvcfs/HG00444.haplotypeCalls.er.raw.vcf.gz.vcf.gz", | ||
| "gs://fc-2b4456d7-974b-4b67-90f8-63c2fd2c03d4/gvcfs/HG00447.haplotypeCalls.er.raw.vcf.gz.vcf.gz", | ||
| "gs://fc-2b4456d7-974b-4b67-90f8-63c2fd2c03d4/gvcfs/HG00450.haplotypeCalls.er.raw.vcf.gz.vcf.gz" | ||
| "gs://gvs-internal-quickstart/reblocked-v2-vcfs/HG00405.haplotypeCalls.er.raw.vcf.gz.rb.g.vcf.gz", |
There was a problem hiding this comment.
should I be worried that the "example" output VCFs in the Beta workspace now might look slightly different? Or actually, this reblocking change in theory should not alter the outcome....just the cost and efficiency of the pipeline, right?
RoriCremer
approved these changes
Jun 29, 2022
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://broadworkbench.atlassian.net/browse/VS-491