Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the broken test in DirichletAlleleDepthAndFractionIntegrationTest #7963

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

jamesemery
Copy link
Collaborator

No description provided.

@jamesemery jamesemery requested a review from droazen July 25, 2022 19:03
@gatk-bot
Copy link

gatk-bot commented Jul 25, 2022

Github actions tests reported job failures from actions build 2734621260
Failures in the following jobs:

Test Type JDK Job ID Logs
integration 11 2734621260.12 logs
integration 8 2734621260.0 logs

@jamesemery jamesemery force-pushed the je_fixMissedRegenerateTestDataSwitch branch from 404fd43 to 6acde88 Compare July 27, 2022 19:28
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #7963 (6acde88) into master (f1e7265) will increase coverage by 0.001%.
The diff coverage is 100.000%.

@@               Coverage Diff               @@
##              master     #7963       +/-   ##
===============================================
+ Coverage     86.689%   86.690%   +0.001%     
- Complexity     38394     38396        +2     
===============================================
  Files           2308      2308               
  Lines         180119    180122        +3     
  Branches       19823     19823               
===============================================
+ Hits          156143    156148        +5     
+ Misses         17036     17033        -3     
- Partials        6940      6941        +1     
Impacted Files Coverage Δ
...irichletAlleleDepthAndFractionIntegrationTest.java 100.000% <100.000%> (ø)
...itute/hellbender/tools/LocalAssemblerUnitTest.java 92.448% <0.000%> (ø)
.../hellbender/utils/python/PythonUnitTestRunner.java 78.689% <0.000%> (+3.279%) ⬆️

Copy link
Collaborator

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @jamesemery Any idea why the test results didn't need to change as well (I made a PR to do this a few months ago and I had to update the outputs because they had changed, but we didn't notice because they were being overwritten every time - see #7563).

@lbergelson lbergelson merged commit b203569 into master Dec 23, 2022
@lbergelson lbergelson deleted the je_fixMissedRegenerateTestDataSwitch branch December 23, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants