VariantAnnotator fails when the variant contains too many alleles #8075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now issues a warning
ilyasoifer
force-pushed
the
annotator.dbsnp.fix
branch
from
b75d501
to
516d95c
Compare
meganshand
reviewed
Oct 27, 2022
| return variantOverlapAnnotator.annotateOverlaps(features, variantOverlapAnnotator.annotateRsID(features, annotated)); | ||
| try { | ||
| return variantOverlapAnnotator.annotateOverlaps(features, variantOverlapAnnotator.annotateRsID(features, annotated)); | ||
| } catch (IllegalArgumentException e) { |
There was a problem hiding this comment.
As we discussed in person, I think we should check that other errors that aren't intended to be caught are not caught here. I just want to be sure that we don't change the default behavior for unrelated variant annotations if they would have failed here.
|
@meganshand - is this change better now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour had been switched to warning