Add DeprecatedFeature annotation. #8100
Conversation
|
Github actions tests reported job failures from actions build 3527272492
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8100 +/- ##
===============================================
+ Coverage 84.069% 86.604% +2.535%
- Complexity 37456 38940 +1484
===============================================
Files 2335 2335
Lines 182679 182680 +1
Branches 20052 20052
===============================================
+ Hits 153577 158209 +4632
+ Misses 22059 17433 -4626
+ Partials 7043 7038 -5
|
cmnbroad
force-pushed
the
cn_deprecation_tag
branch
2 times, most recently
from
a428cff
to
8940fae
Compare
There was a problem hiding this comment.
@cmnbroad Minor comments.
It might be nice to replace the (Deprecated) mark in the html with something more like the little bubbles for the input type so it stands out a bit more. (even if it's in its own dedicated section.)
| @@ -32,7 +33,7 @@ public class HaplotypeCallerReadThreadingAssemblerArgumentCollection extends Rea | |||
| /** | |||
| * As of version 3.3, this argument is no longer needed because dangling end recovery is now the default behavior. See GATK 3.3 release notes for more details. | |||
| */ | |||
| @Deprecated | |||
| @DeprecatedFeature | |||
There was a problem hiding this comment.
This has been deprecated since 3.3... maybe we can remove it.
There was a problem hiding this comment.
Can we put the reason in the description?
| @@ -115,7 +116,7 @@ public ReadThreadingAssembler createReadThreadingAssembler(){ | |||
| public File f1r2TarGz; | |||
|
|
|||
| // As of GATK 4.1, any sample not specified as the normal is considered a tumor sample | |||
| @Deprecated | |||
| @DeprecatedFeature | |||
There was a problem hiding this comment.
Should we move the reason into here?
| @@ -61,7 +62,7 @@ public GenotypeCalculationArgumentCollection clone() { | |||
| /** | |||
| * As of version 4.1.0.0, this argument is no longer needed because the new qual score is now on by default. See GATK 3.3 release notes for more details. | |||
There was a problem hiding this comment.
Does javadoc on arguments get output in our docs at all?
There was a problem hiding this comment.
Yes, it gets included in the full text description.
cmnbroad
force-pushed
the
cn_deprecation_tag
branch
from
8940fae
to
fa51f93
Compare
|
@cmnbroad Are we waiting on something to merge this? 👍 from me. |
cmnbroad
force-pushed
the
cn_deprecation_tag
branch
from
fa51f93
to
d8d7f27
Compare
Upgrades Barclay to 4.1.0. Adds an
@DeprecatedFeatureannotation that can be applied to any@DocumentedFeatureor@Argument, and updates the handful of such features that are already tagged with the standard Java annotation@Deprecatedto use the new annotation. Mutually exclusive with@Betaand@Experimental.The output for
--use-new-qual-calculator: