Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java 11.0.11+9 for testing, upgrade hadoop to v3.3.1. #8102

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

cmnbroad
Copy link
Collaborator

No description provided.

@cmnbroad cmnbroad marked this pull request as draft November 22, 2022 22:20
@gatk-bot
Copy link

Github actions tests reported job failures from actions build 3533672613
Failures in the following jobs:

Test Type JDK Job ID Logs
integration 11 3533672613.12 logs

@cmnbroad
Copy link
Collaborator Author

cmnbroad commented Nov 28, 2022

This is super interesting - the Java 11 integration tests that are failing in this last run are exactly the same tests that have been problematic on the Java 17 branch. I looked at the failing values that were being produced on that branch (which we've updated), and they're identical to the failing values seen here. Even on the Java 17 branch, there has been some inconsistency in the failures (they usually fail, but not always).

@cmnbroad cmnbroad changed the title Try upgrading hadoop to v3.3.1. Pin to Java 11.0.11+9 for testing, upgrade hadoop to v3.3.1. Nov 29, 2022
@cmnbroad cmnbroad marked this pull request as ready for review November 29, 2022 14:34
@cmnbroad cmnbroad changed the title Pin to Java 11.0.11+9 for testing, upgrade hadoop to v3.3.1. Use Java 11.0.11+9 for testing, upgrade hadoop to v3.3.1. Nov 29, 2022
@cmnbroad
Copy link
Collaborator Author

Technically, the Hadoop upgrade is not required for this, since we're temporarily reverting back to a Java 11 version that doesn't trigger the version parsing issues that surface with older Haddop/Jetty versions, but we may as well keep it, since we'll need it once we fix the ModelSegments tests and switch back to using current Java 11 versions.

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gross but necessary. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants