Make several Funcotator methods and fields protected #8166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to extend the tool
|
@jonn-smith would it be possible to make two more methods public, this time from FuncotatorEngine? If so, would it be possible to push a nightly build, similar to what @lbergelson did here: #8138 |
|
@jonn-smith: sorry to bug, but wanted to see if you'd approve this minor PR. |
lbergelson
approved these changes
Jan 31, 2023
|
@lbergelson: thanks for your help. looks like the tests passed |
|
@bbimber I pushed it up as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make several Funcotator methods and fields protected so it is easiest to extend the tool