Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue causing VariantRecalibrator to sometimes fail if user provides duplicate -an options #8227

Conversation

KevinCLydon
Copy link
Member

Modified VariantRecalibrator to only use a deduped version of the annotations list provided by the user once the list has been deduped. Previously it was still sometimes using the list that could have duplicates

Fixes #8226

Also fixed the logger warning that prints the duplicate annotations.

…This resolves issues that can result from differences in the number of annotations in the original and deduped lists. Also fixed the logger warning that prints the duplicate annotations.
Copy link
Contributor

@ldgauthier ldgauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant. I guess I missed this case when I did the .distinct() bugfix a while ago.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #8227 (e0f07ef) into master (24f62de) will increase coverage by 0.000%.
The diff coverage is 90.000%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #8227   +/-   ##
===========================================
  Coverage     86.654%   86.655%           
  Complexity     39168     39168           
===========================================
  Files           2346      2346           
  Lines         183670    183675    +5     
  Branches       20152     20152           
===========================================
+ Hits          159158    159163    +5     
- Misses         17449     17451    +2     
+ Partials        7063      7061    -2     
Impacted Files Coverage Δ
...bender/tools/walkers/vqsr/VariantRecalibrator.java 86.168% <66.667%> (ø)
...lbender/tools/walkers/vqsr/VariantDataManager.java 78.947% <100.000%> (ø)
...lkers/vqsr/VariantRecalibratorIntegrationTest.java 98.361% <100.000%> (+0.046%) ⬆️
...itute/hellbender/tools/LocalAssemblerUnitTest.java 92.448% <0.000%> (ø)

@KevinCLydon KevinCLydon merged commit 227bbca into master Feb 28, 2023
@KevinCLydon KevinCLydon deleted the kl_variantrecalibrator_duplicate_annotations_indexoutofbounds_8226 branch February 28, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VariantRecalibrator produces ArrayIndexOutOfBoundsException with duplicate -an options and --rscript-file
2 participants