Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed a line in FlowBasedAnnotation that contained a bug and thus was meaningless #8421

Conversation

ilyasoifer
Copy link
Collaborator

No description provided.

@ilyasoifer ilyasoifer changed the title Removed a line that contained a bug and thus was meaningless Removed a line in FlowBasedAnnotation that contained a bug and thus was meaningless Jul 16, 2023
Copy link
Contributor

@meganshand meganshand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment

@@ -57,7 +58,7 @@ public Object[][] getTestData() {
{
// not hmer indel
"TATCT CA TTGACCAA", "C",
"del", "1", "1", "A", "ATCTC", "TTGAC", "0.3", "NA", "non-h-indel"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can update the comment above this test case since it is now considered an hmer

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ilyasoifer ilyasoifer merged commit 32933b4 into broadinstitute:master Jul 20, 2023
@ilyasoifer ilyasoifer deleted the ilyasoifer/fix.h-indel.definition.bug branch July 20, 2023 18:34
rickymagner pushed a commit that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants