Update http-nio and wire its new settings #8611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lbergelson
commented
Dec 8, 2023
lbergelson
commented
- it now has a retry mechanism so we're asking for a lot of retries
* it now has a retry mechanism so we're asking for a lot of retries
droazen
approved these changes
Dec 8, 2023
| @@ -55,6 +54,8 @@ public final class BucketUtils { | |||
|
|
|||
| // slashes omitted since hdfs paths seem to only have 1 slash which would be weirder to include than no slashes | |||
| public static final String FILE_PREFIX = "file:"; | |||
| public static final int MAX_TIMEOUT = 120000; | |||
| public static final int MAX_ATTEMPTS = 15; | |||
There was a problem hiding this comment.
How is this hardcoded MAX_ATTEMPTS related to maxRetries?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.