Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http-nio to 1.1.1 #8889

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Update http-nio to 1.1.1 #8889

merged 1 commit into from
Jun 27, 2024

Conversation

droazen
Copy link
Contributor

@droazen droazen commented Jun 24, 2024

This release fixes several bugs when using HttpPath resolve methods that have been affecting users. In particular, they were causing issues when trying to construct HTTP URIs for companion files such as fasta/bam indices.

@droazen droazen requested a review from lbergelson June 24, 2024 18:28
@lbergelson
Copy link
Member

@droazen What's the status of the failing WDL tests?

@droazen droazen force-pushed the dr_update_httpnio_to_1.1.1 branch from 68b523f to e7c7705 Compare June 27, 2024 18:29
@droazen
Copy link
Contributor Author

droazen commented Jun 27, 2024

@lbergelson The branch just needed a rebase -- re-running tests now

Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0.0.1

@droazen droazen merged commit adbb626 into master Jun 27, 2024
21 checks passed
@droazen droazen deleted the dr_update_httpnio_to_1.1.1 branch June 27, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants