-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CollectQualityYieldMetricsFlowSpace tool #1932
Merged
meganshand
merged 35 commits into
broadinstitute:master
from
Ultimagen:CollectQualityYieldMetricsFlowSpace-dev
May 2, 2024
Merged
Changes from 30 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
29e9052
CollectQualityYieldMetricsFlowSpace dev
dror27 f1b69fe
add flow read params to test
dror27 9725c73
Minimimal reported error probability now calculated from the read.
ilyasoifer 9264fab
removed unused flow code
dror27 b5a041d
remove FLOW_MODE from CollectQualityYieldMatrics
dror27 20856b9
FlowSpace -> Flow (simplify tool name)
dror27 8080de6
histograms added
dror27 65e46fa
histogram update
dror27 f6fc79f
Cleaner treatment of fillingValue + fixed a bug in parsing T0
ilyasoifer 9893f06
restore test passing
dror27 9dd738b
Code cleanup + INCLUDE_BQ_HISTOGRAM parameter
dror27 e9996ed
MEAN_READ_NAME
dror27 8f4f5f1
remove @Hidden
dror27 ecdedfb
Fixed crash on unaligned reads, reads with no bases and a typing error
ilyasoifer a41401f
ceil -> round
ilyasoifer 351988e
PCT_Q20/Q30_FLOWS added
dror27 da63a41
CollectSNVQualityYieldMetrics tool
dror27 d9579c5
SNVQ stats
dror27 f542c85
Quals taken from BQ
dror27 e78c84c
Small refactoring - PCT_Q20_FLOWS -> PCT_PF_Q20_FLOWS etc.
ilyasoifer 8ed29f5
CollectQualityYieldMetricsFlow changes
dror27 5fada25
CollectQualityYieldMetricsSNVQTest changes
dror27 d806ff1
Typo fix
ilyasoifer aaa0c34
zero base BQ values
dror27 cd76c23
Update SeriesStats.java
dror27 14806b8
Cleaner treatment of fillingValue + fixed a bug in parsing T0
ilyasoifer 1576d5b
qual range warnings added
dror27 8d188c5
code cleanup (of unused methods, etc)
dror27 7bd235b
various comments addressed
dror27 780c0da
Rename short name for USE_BQ_FOR_BASE_QUALITIES
dror27 411a75d
addressing pull request comments
dror27 59278aa
flow core code moved to picard
dror27 fd8b16d
test (double,double) assertions made compatible with future test fram…
dror27 bd50c59
Revert "test (double,double) assertions made compatible with future t…
dror27 e3d0557
FlowBasedHaplotype removed from picard
dror27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change won't be backwards compatible with the previous version of Picard. That's ok with me since you're probably aware of most Ultima users using this tool, but wanted to note it in case you'd rather throw an error message pointing them to
CollectQualityYieldMetricsFlow
if they provideFLOW_MODE
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good advice. Restored FLOW_MODE on CollectQualityYieldMetrics. When set, now throws an exception and points to CollectQualityYieldMetricsFlow