Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
highQualityDepthHistogramNonZero
as a histogram variable to WgsMetrics.java and CollectTargetMetrics.java.highQualityDepthHistogramNonZero
is identical tohighQualityDepthHistogram
, but gets rid of its '0 coverage' bin.highQualityDepthHistogramNonZero
is then used in the place of thehighQualityDepthHistogram
for the calculation of theFOLD_80_BASE_PENALTY
metric. The motivation for making this change is to have these metrics accurately calculate theFOLD_80_BASE_PENALTY
metric accord to its definition: "The fold over-coverage necessary to raise 80% of bases in "non-zero-cvg" targets to the mean coverage level in those targets."This change fixes the issue brought up in the following Picard Bug Report.
Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests