Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

everything is single threaded now? #911

Closed
dpark01 opened this issue Jan 17, 2019 · 2 comments
Closed

everything is single threaded now? #911

dpark01 opened this issue Jan 17, 2019 · 2 comments

Comments

@dpark01
Copy link
Member

dpark01 commented Jan 17, 2019

When executing command line viral-ngs in google cloud, either within a conda environment on a manually created VM, or within dsub/PAPIv2, I'm noticing that --threads 1 is being passed to pretty much every subprocess call.

I note two possible bugs here:

  1. Should this say cfs_period_us instead of cfs_quota_us?
  2. In my environments, cfs_quota_us is reporting -1, perhaps using that value to denote unlimited quota. This means available_cpu_count() is always reporting 1 instead of the number of processors available on the machine. This line should change to treat -1 as infinity.
@tomkinsc
Copy link
Member

Can we close this now that #912 has been merged?

@dpark01
Copy link
Member Author

dpark01 commented Feb 20, 2019

Yes, similar to the other PR, I think @notestaff 's description of PR #912 needed to say "fixes" or "closes" #911 before it merged, in order for merging to close this issue.

@dpark01 dpark01 closed this as completed Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants