Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to tbl_transfer_prealigned oob_clip #807

Merged
merged 4 commits into from
Mar 30, 2018
Merged

fixes to tbl_transfer_prealigned oob_clip #807

merged 4 commits into from
Mar 30, 2018

Conversation

dpark01
Copy link
Member

@dpark01 dpark01 commented Mar 30, 2018

Fixes and updates to tbl_transfer_prealigned --oob_clip behavior. Specifically:

  1. CDS features are handled a bit specially: the 5' end is trimmed in multiples of 3 to retain original reading frame. 3' ends are still trimmed as-is.
  2. oob_clip behavior was buggy for negative strand features: if the right end of the genome caused the 5' of a negative strand feature to be clipped, it was previously getting recorded as <1 which caused it to become positive stranded and encode the wrong half of the genome. This is now trimming to the right end of the genome instead (except with CDS features which get rounded off to the nearest multiple of 3).

… when clipping features on the negative strand. also incorporate CDS rounding by 3 during clipping for these cases too.
@tomkinsc tomkinsc merged commit cd86d7a into master Mar 30, 2018
@tomkinsc tomkinsc deleted the dp-genbank branch March 30, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants