conftest.py fixes #840
conftest.py fixes #840
Conversation
and to check if the tempdir still exists before trying to erase it. In tmpdir_function() switch to using monkeypatch; this fixes a bug where if TMPDIR was originally unset it will be left set to the now-deleted tempdir.
conftest.py
Outdated
| @@ -29,46 +31,44 @@ def pytest_configure(config): | |||
| reporter = FixtureReporter(config) | |||
| config.pluginmanager.register(reporter, 'fixturereporter') | |||
|
|
|||
| def _max_fname_len(file_system_path, default_max_len=80): | |||
| name_max_str = [s for s in os.pathconf_names if s.endswith('_NAME_MAX')] | |||
There was a problem hiding this comment.
this is for a (prefix of) a path component, not full path
There was a problem hiding this comment.
turning into iterators is for specifying cleanup actions after fixture goes out of scope
conftest.py
Outdated
| pass | ||
| return default_max_len | ||
|
|
||
| def _make_fname_valid(file_system_path, fname, len_margin): |
There was a problem hiding this comment.
What's invalid about non-ascii filenames? Is there any reason this needs to be enforced?
There was a problem hiding this comment.
(if it does need to be enforced, we have util.file.string_to_file_name())
There was a problem hiding this comment.
Actually the commented out portions of that function show that we made a point of allowing unicode filenames, we just disallowed certain pathsep or escape characters.
conftest.py
Outdated
| name = _make_fname_valid(file_system_path=basetemp, fname=name, len_margin=50) | ||
| tmpdir = tempfile.mkdtemp(dir=basetemp, prefix='test-{}-{}-'.format(scope, name)) | ||
| yield tmpdir | ||
| if os.path.isdir(tmpdir): shutil.rmtree(tmpdir) |
There was a problem hiding this comment.
Don't we still think we should shutil.rmtree(ignore_errors=True)? Our error before in #839 was not about the tmpdir not existing, it was about a file within the tmpdir disappearing while rmtree was in the middle of walking the tree.
And if we ignore_errors=True then the if os.path.isdir becomes unnecessary as a side effect.
…test.py to use it.
Changed tmpdir_{session,module,function} to use tempfile.mkdtemp(), and to check if the tempdir still exists before trying to erase it.
In tmpdir_function() switch to using monkeypatch; this fixes a bug
where if TMPDIR was originally unset it will be left set to the
now-deleted tempdir.