-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding commands for working with kmer sets using the KMC tool. #854
Conversation
contigs based on kmers.
Periodically, coverall erroneously reports big drops in coverage. Is there a known workaround? |
I think the exact reason for that has varied over time... in the past we used to do more test skipping in certain build scenarios (which I think we don't do as much now.. though there is still some, for example, most of the tool install tests are skipped unless it's a tagged release). Sometimes it might be because the PR's merge structure is funny and coveralls might not be comparing to the right comparison point (but this particular instance looks like a clean merge). In any case, this is why I've changed the coveralls test to be a non-blocking hook in github--it doesn't prevent a merge of a PR, but it's a useful data point to have. |
It's definitely a useful data point in general. In this specific case, the reason I think the data is incorrect is that a tiny change ( 58ce922 ) caused a 41% drop in coverage. |
I think it's because the long and short tests are run separately and have different amounts of coverage. If only one side is updated and rerun it overwrites the old coveralls report and I don't think it has the ability to merge reports |
But pushing a commit runs all parts of the build matrix, and they all have --cov-append, no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a useful set of additions to me. Sorry it looked like it was also under quite a bit of motion at one point so I wasn't sure when the best time to review was.
Adding commands for working with kmer sets using the KMC tool. Some planned uses: recovering currently depleted but relevant reads; evaluating optimality of assemblies and finding potentially fillable gaps; generating fine-grained reports on the occurrence in the known reference sequences of raw read kmers.