Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dxWDL 0.72: revert WDLs to unbound task inputs #857

Merged
merged 8 commits into from
Jul 23, 2018
Merged

dxWDL 0.72: revert WDLs to unbound task inputs #857

merged 8 commits into from
Jul 23, 2018

Conversation

dpark01
Copy link
Member

@dpark01 dpark01 commented Jul 21, 2018

The recent bump to dxWDL 0.69 brought with it a limitation that required task input variables were not allowed to be left unbound at the workflow level. This resulted in significant new additions of redundant WDL variables at the workflow level and, more importantly, a resulting DNAnexus workflow that aggregated all input variables at the top common stage, regardless of which stage it was actually used in (and this broke output caching, etc).

dxWDL 0.72 now compiles simple WDL top-level tasks directly to DNAnexus stages which allows us to leave these required inputs at the task level. Resulting UI is much prettier (well, same as before really).

The only case this isn't identical to before is with required inputs within complex stages (scatters, conditionals, subworkflows), such as all of the scattered tasks within demux_plus which still require all of their inputs to be percolated up to the common stage. Also, all of their optional params are hidden unless we manually replicate them out to the workflow level.

@dpark01 dpark01 requested a review from tomkinsc July 23, 2018 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants