Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lk add starsolo barcode metrics #1044

Merged
merged 29 commits into from
Jul 21, 2023
Merged

Conversation

ekiernan
Copy link
Contributor

@ekiernan ekiernan commented Jul 17, 2023

Description

We've had requests to include STARsolo per barcode metrics as an output to the Optimus workflow. This PR creates a new output (aligner_metrics) that includes the combined per barcode metrics across all shards to the Starsolo alignment task.

Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP documentation team by tagging either @ekiernan or @kayleemathews in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

File align_features_sn_rna = "Features_sn_rna.stats"
File summary_sn_rna = "Summary_sn_rna.csv"
File umipercell_sn_rna = "UMIperCellSorted_sn_rna.txt"
#File aligner_metrics = "~{output_bam_basename}.star_metrics.tar"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still want this commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it. I'm going to delete it entirely.

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@@ -337,31 +338,52 @@ task STARsoloFastq {
--soloUMIdedup 1MM_Directional_UMItools \
--outSAMtype BAM SortedByCoordinate \
--outSAMattributes UB UR UY CR CB CY NH GX GN \
--soloBarcodeReadLength 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we typically run star twice? Is it possible to run it just once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We run it twice for the count_exons = true. With the latest version of STAR, we should be able to run both parameters in a single STAR run. We haven't yet played with that functionality.

Copy link
Member

@jessicaway jessicaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @ekiernan!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@github-actions
Copy link

Remember to squash merge!

@ekiernan
Copy link
Contributor Author

retest this please

@ekiernan ekiernan merged commit 9c558df into develop Jul 21, 2023
3 checks passed
@ekiernan ekiernan deleted the lk-add-starsolo-barcode-metrics branch December 20, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants