Drop support for Node 4, 6, 7, and 9 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SparshithNR
commented
Nov 6, 2019
SparshithNR
commented
- only LTS node is supported.
- Node 8, 10, 12 is added
1. only LTS node is supported. 2. Node 8, 10, 12 is added
rwjblue
changed the title
rwjblue
changed the title
|
Looks like we have some failing tests under Node 10/12, mind taking a look? |
|
@rwjblue Tests are breaking because of a bug in windows implementation of checking if symlink exists or not. I created an issue in the nodeJS project. |
Use fs.removeSync to remove folders
SparshithNR
force-pushed
the
node-update
branch
from
bcfd9a9
to
96cdac6
Compare
|
Fixed the issue by adding a function that will do |
stefanpenner
requested changes
Dec 4, 2019
|
working on this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.