Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing windows test with a temporary workaround #124

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Fixing windows test with a temporary workaround #124

merged 1 commit into from
Feb 20, 2020

Conversation

SparshithNR
Copy link
Contributor

@SparshithNR SparshithNR commented Feb 20, 2020 •
edited
Loading

Perhaps exists should just check both access and stat on Windows...

Code tries to do as mentioned in the comment and the fix provided into nodeJS nodejs/node@366a45b

krisselden
krisselden approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@krisselden krisselden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@SparshithNR SparshithNR mentioned this pull request Feb 20, 2020
Merged
@stefanpenner stefanpenner merged commit a6aa9dc into broccolijs:master Feb 20, 2020
@stefanpenner
Copy link
Contributor

released as v3.0.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisselden krisselden krisselden approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SparshithNR @stefanpenner @krisselden