Have Brocfile.js export a function #386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the basics needed for Brocfile to return a function by default, and wrap existing brocfile exports in a function for backwards compatibility.
The intention for this is to make Broccoli work the same as Ember-CLI (to avoid confusion), and it also paves the way for us to pass in a configuration object containing things like
environment
and other build-time useful info (as Ember-CLI does).One thing to note, is
broccoli/lib/index.js
Lines 7 to 9 in b5e4c8b