Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --environment CLI option and Brocfile argument #387

Merged
merged 7 commits into from
Feb 19, 2019
Merged

Support --environment CLI option and Brocfile argument #387

merged 7 commits into from
Feb 19, 2019

Conversation

oligriffiths
Copy link
Contributor

This PR implements an options object being passed to the build function.

stefanpenner
stefanpenner approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@stefanpenner stefanpenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Does -e work as a shorthand?

@oligriffiths
Copy link
Contributor Author

@stefanpenner not right now. I’ll add that

@oligriffiths oligriffiths merged commit dbaf207 into master Feb 19, 2019
@oligriffiths oligriffiths deleted the environment branch February 19, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanpenner stefanpenner stefanpenner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oligriffiths @stefanpenner