Add more watcher events

[oligriffiths]

In order to support the Broccoli watcher in Ember CLI ember-cli/ember-cli#8614, we need more information about the change event and some other events in order to replicate the existing Ember CLI functionality.

I added a test for Watcher as there didn't seem to be one. Plz lmk if I've done anything wrong.

Will add some tests, just wanted to get this open for now.

[stefanpenner]

LGTM, but add tests ;)

[oligriffiths]

@stefanpenner @thoov added tests, this should be good to review now

[oligriffiths]

@stefanpenner added a test for Watcher as there doesn't seem to be one. Confused about a couple of things:

1. What is _lifetimeDeferred about?
2. If the build promise rejects with a failure, I don't see _error being called

   broccoli/lib/watcher.js

   Line 51 in d152c60

   .catch(err => this._error(err))

   I was debugging this test

   broccoli/test/watcher_test.js

   Line 60 in d152c60

   it('calls error if build rejects', function() {

   and asserting that quitStart was called, but it's not. Added some breakpoints and confirmed _error is not called. Is this right?

[oligriffiths]

Ugh apvoyer failed, claims tests failed, dunno why...

[thoov]

@oligriffiths Looks like the tests are failing for lint reasons. Could you fix that then LGTM!

[oligriffiths]

Will fix. Heading to a flight rn tho

[oligriffiths]

@thoov fixed tests. Ready to rock

[oligriffiths]

👏