Use a more appropriate data structure for nodeWrappers. #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
changed the title
stefanpenner
changed the title
|
I think we should also add heimdall instrumentation for https://github.com/broccolijs/broccoli/blob/master/lib/builder.js#L170 |
thoov
approved these changes
Jul 26, 2019
rwjblue
reviewed
Jul 30, 2019
| @@ -143,8 +143,11 @@ module.exports = class Builder extends EventEmitter { | |||
| this.buildHeimdallTree(outputNodeWrapper); | |||
| }), | |||
| () => { | |||
| let buildsSkipped = this.nodeWrappers.filter(nw => nw.buildState.built === false).length; | |||
| logger.debug(`Total nodes skipped: ${buildsSkipped} out of ${this.nodeWrappers.length}`); | |||
| let buildsSkipped = filterMap( | |||
There was a problem hiding this comment.
Note for a future iteration: it would be really nice if heimdall-logger provided a way to conditionally emit logging info. Right now we are forced to eagerly calculate the debugging output when in 99% of the time its never consumed / reviewed.
rwjblue
approved these changes
Jul 30, 2019
Since NodeWrappers lists: * must be insertion ordered * must contain only unique values (based on their key) * support a fast existence / lookup operation This PR switches it from an array to a map. As broccoli pipelines grow large, simply searching the array to detect duplicates on insertion can become very costly, and switching to a Map addresses this specific bottleneck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a more appropriate data structure for nodeWrappers.
Since NodeWrappers lists:
This PR switches it from an array to a map.
As broccoli pipelines grow large, simply searching the array to detect duplicates on insertion can become very costly, and switching to a Map addresses this specific bottleneck.