Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1RM estimate (Brzycki's formula) #185

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Add 1RM estimate (Brzycki's formula) #185

merged 2 commits into from
Jan 6, 2021

Conversation

realGWM
Copy link
Contributor

@realGWM realGWM commented Jan 3, 2021

Fixes #181

This patch adds 1RM (One Rep Max, see: https://en.wikipedia.org/wiki/One-repetition_maximum) estimation with Brzycki's formula to the charts.

Brzycki's (1) formula was chosen over Epley's (2) formula mainly because of ease of implementation ((2) does not work with 1rep).
(1) and (2) give exactly the same results for 10 reps, but for less than 10 reps (2) gives a slightly higher estimated maximum.
According to https://opensiuc.lib.siu.edu/cgi/viewcontent.cgi?article=1744&context=gs_rp (I've only read the conclusion at the end actually), (1) is more precise at 5 reps while (2) is more precise at 3 reps.

I decided to set the reps limit to 10 because it is believed that the formula becomes highly inaccurate for more than 10 reps, feel free to change this value if you want to.

@brodeurlv brodeurlv merged commit eef8803 into brodeurlv:master Jan 6, 2021
@brodeurlv
Copy link
Owner

Thanks @realGWM, I will include this in the next release.

@realGWM
Copy link
Contributor Author

realGWM commented Jan 6, 2021

I've just noticed that I forgot to remove unused import android.database.Cursor; from the PR, and Android Studio tells me that this is now the only unused import in the whole project 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add estimated 1 RepMax to charts
2 participants